Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URO-163, URO-165, URO-166, URO-167: API calls for Copy, Link, Rename and Restore components #107

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

dakotablair
Copy link
Collaborator

@dakotablair dakotablair commented Sep 11, 2023

  • URO-163: Narratives can be copied to a new narrative with the specified name using the Narrative Control Menu.
    • If the action fails then this is shown to the user using a toast notification. Have distinct messages for when:
      • The specified name is not valid (enforced through UI validation).
      • The app cannot confirm action success.
  • URO-165: Narratives can be renamed to the specified name using the Narrative Control Menu.
    • If the action fails then this is shown to the user using a toast notification. Have distinct messages for when:
      • The specified name is not valid (enforced through UI validation).
      • The app cannot confirm action success.
  • URO-166: Narratives can be restored to the specified version using the Narrative Control Menu.
    • If the action fails then this is shown to the user using a toast notification. Have distinct messages for when:
      • The app cannot confirm action success.
  • URO-167: Narratives can be linked with the specified Org using the Narrative Control Menu.
    • If the action fails then this is shown to the user using a toast notification. Have distinct messages for when:
      • The app cannot confirm action success.
  • Fix automatic refresh bug.

@dakotablair dakotablair marked this pull request as ready for review September 14, 2023 20:42
@dakotablair dakotablair changed the title URO-163, URO-165, URO-166: API calls for Copy, Rename and Restore components URO-163, URO-165, URO-166, URO-167: API calls for Copy, Link, Rename and Restore components Sep 15, 2023
Copy link
Collaborator

@dauglyon dauglyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but approved

src/common/api/orgsApi.ts Show resolved Hide resolved
src/common/api/serviceWizardApi.ts Show resolved Hide resolved
src/common/components/Input.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants